Supporting several additional OpenScenario 1.0 tags #1014
Conversation
fix bug of add new tags
|
@germanros1987 @glopezdiest We have re-created the PR for openscenario 1.0 new tags support, please ignore previous one #987 |
|
Is there any feedback? @germanros1987 |
|
@joel-mb can you review this, please? |
|
@synkrotron Hey, I tried it and seems like there is some issue with waypoint based scenarios. Do you tried with waypoint based scenarios also? |
Hello, do you have an example? |
Hey, I just posted this in https://github.com/guardstrikelab/scenario_runner as an issue. |
|
Hey @synkrotron, could you please resolve the conflicts so that we can merge the PR? |
|
Hi, @germanros1987, I resolved the code conflict by deleting the original branch 'feature/new_tags_support' and creating a new one (also named 'feature/new_tags_support') based on the master branch. However, it appears that this Pull Request has not been updated. Should I close this PR and create a new one? |
There was a problem hiding this comment.
Reviewed 6 of 11 files at r1, 1 of 5 files at r2, 3 of 5 files at r3, 6 of 6 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @joel-mb)
|
That's okay, there are no more conflicts, so we can merge the PR |
Description
We've added some new tags that weren't supported before, as shown in Changelog.md and openscenario_support.md.
Where has this been tested?
Possible Drawbacks
We did complete tests and found no errors.
This change is